Skip to content

Fix flake8 with noqa: E731 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2024
Merged

Fix flake8 with noqa: E731 #84

merged 1 commit into from
Sep 14, 2024

Conversation

bobleesj
Copy link

To expedite cookiecutting, I have added noqa: E731.

All flake8 errors have been resolved.

I created an issue to re-address it - #83

@bobleesj bobleesj marked this pull request as ready for review September 10, 2024 01:57
@bobleesj
Copy link
Author 

imac@imacs-iMac diffpy.srfit % python -m diffpy.srfit.tests.run            
WARNING:diffpy.srfit.tests:No module named 'sas', SaS tests skipped.
WARNING:diffpy.srfit.tests:Cannot import diffpy.structure, Structure tests skipped.
WARNING:diffpy.srfit.tests:Cannot import pyobjcryst, pyobjcryst tests skipped.
WARNING:diffpy.srfit.tests:Cannot import diffpy.srreal, PDF tests skipped.
......ssss...........sss..................sssssssssss....ssssss...........................ssssss..............
----------------------------------------------------------------------
Ran 110 tests in 0.058s

OK (skipped=30)

Tests running locally.

@bobleesj
Copy link
Author

@sbillinge If you have a minute, could you please review this?

The next step for diffpy.srfit to implement CI after restructuring tests/src folders.

@sbillinge sbillinge merged commit f1162a6 into diffpy:cookie Sep 14, 2024
1 check failed
@sbillinge
Copy link
Contributor

@bobleesj this failed pre-commit because of the meta.yaml, but this will be addressed in the recookiecut I believe (we will delete that file) and I like the change you did here, so I merged it like that.

@bobleesj bobleesj deleted the cookie-lambda branch September 14, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobleesj @sbillinge